Skip to content

[STORM-1975] Support default value for KafkaBolt #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darionyaphet wants to merge 1 commit into from
Closed

[STORM-1975] Support default value for KafkaBolt #1570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions external/storm-kafka/src/jvm/org/apache/storm/kafka/bolt/KafkaBolt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,23 +56,36 @@ public class KafkaBolt<K, V> extends BaseRichBolt {

private static final Logger LOG = LoggerFactory.getLogger(KafkaBolt.class);

public static final String TOPIC = "topic";
private static final String TOPIC = "topic";

private static final String DEFAULT_KEY_SERIALIZER = "org.apache.kafka.common.serialization.StringSerializer";
private static final String DEFAULT_VALUE_SERIALIZER = "org.apache.kafka.common.serialization.StringSerializer";
private static final String DEFAULT_ACKS = "1";

private KafkaProducer<K, V> producer;
private OutputCollector collector;
private TupleToKafkaMapper<K,V> mapper;
private TupleToKafkaMapper<K,V> mapper = new FieldNameBasedTupleToKafkaMapper<>();
private KafkaTopicSelector topicSelector;
private Properties boltSpecfiedProperties = new Properties();
/**
* With default setting for fireAndForget and async, the callback is called when the sending succeeds.
* By setting fireAndForget true, the send will not wait at all for kafka to ack.
* "acks" setting in 0.8.2 Producer API config doesn't matter if fireAndForget is set.
* By setting async false, synchronous sending is used.
* By setting async false, synchronous sending is used.
*/
private boolean fireAndForget = false;
private boolean async = true;

public KafkaBolt() {}
public KafkaBolt() {
boltSpecfiedProperties.setProperty("acks", DEFAULT_ACKS);
boltSpecfiedProperties.setProperty("key.serializer", DEFAULT_KEY_SERIALIZER);
boltSpecfiedProperties.setProperty("value.serializer", DEFAULT_VALUE_SERIALIZER);
}

public KafkaBolt(String hosts) {
this();
boltSpecfiedProperties.setProperty("bootstrap.servers", hosts);
}

public KafkaBolt<K,V> withTupleToKafkaMapper(TupleToKafkaMapper<K,V> mapper) {
this.mapper = mapper;
Expand Down Expand Up @@ -108,8 +121,8 @@ public void prepare(Map stormConf, TopologyContext context, OutputCollector coll
@Override
public void execute(final Tuple input) {
if (TupleUtils.isTick(input)) {
collector.ack(input);
return; // Do not try to send ticks to Kafka
collector.ack(input);
return; // Do not try to send ticks to Kafka
}
K key = null;
V message = null;
Expand Down