Skip to content

STORM-2180: KafkaSpout ack() should handle re-balance #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
knusbaum wants to merge 2 commits into from
Closed

STORM-2180: KafkaSpout ack() should handle re-balance #1752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ac3b83
Fixing KafkaSpout acking.
knusbaum Oct 31, 2016
2d3d7b1
Fixing spacing.
knusbaum Oct 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,15 @@ private void commitOffsetsForAckedTuples() {
public void ack(Object messageId) {
final KafkaSpoutMessageId msgId = (KafkaSpoutMessageId) messageId;
if (!consumerAutoCommitMode) { // Only need to keep track of acked tuples if commits are not done automatically
acked.get(msgId.getTopicPartition()).add(msgId);
final MessageId msgId = (MessageId) messageId;
TopicPartition partition = msgId.getTopicPartition();
OffsetEntry entry = acked.get(partition);
if (entry == null) {
LOG.warn("Tried to add message with id {} to non-existing partition {}.", msgId, partition);
return;
}
entry.add(msgId);
LOG.debug("Added acked message [{}] to list of messages to be committed to Kafka", msgId);
}
emitted.remove(msgId);
}
Expand Down