Storm-2104 1.0.x #1980
Merged
Storm-2104 1.0.x #1980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
reviewed
Mar 8, 2017
| * Specifying this key deserializer overrides the property key.deserializer | ||
| */ | ||
| public Builder<K,V> setKeyDeserializer(Deserializer<K> keyDeserializer) { | ||
| public Builder<K,V> setKeyDeserializer(SerializableDeserializer<K> keyDeserializer) { |
Contributor
There was a problem hiding this comment.
I'm not 100% sure it keeps binary compatibility. Serializable doesn't have methods so it might work, but just not sure.
Once who makes me clear that this is also safe for binary compatibility, I'll give +1.
(We decided to break backward compatibility for 1.x but not 1.0.x.)
Contributor
Author
There was a problem hiding this comment.
It doesn't. I'll revert this part.
Contributor
|
Thanks for the quick fix. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting #1818 on 1.0.x as well since @qiozas asked about it here #1696
Only change from 1.x version is that
KafkaSpout.emitTupleIfNotEmittedreturns void instead of boolean here.