[STORM-2507] Master branch build failure due to additional checkstyle violations in storm-webapp module #2105
Conversation
…module to reduce checkstyle issue count
| private final Server _httpServer; | ||
| private Thread _handlerServerThread; | ||
| private boolean _closed = false; | ||
| public DRPCServer(Map<String, Object> conf) { |
There was a problem hiding this comment.
This auto-generated formatting this is SOOOOO much less readable to me. Is this because of our checkstyle settings? Removing a newline that separates lines is just wrong, and having method calls with their parameters way to the left of the method names is no bueno.
There was a problem hiding this comment.
Recently we have integrated google_checks.xml and because of that checkstyle rules it is formatting code like that. Most of the changes are reordering methods/fields and removal of extra tabs from beginning of line .
Please give your suggestions on whether to add project specific checkstyle rules in storm
There was a problem hiding this comment.
My experience has been that auto-formatting tools all suck. But I'll try to set aside some time to figure out how to make this one suck a little bit less. I really cannot stand this output, I cannot read it. Humans are not computers, spacing and aesthetics matter a lot.
|
retest this please |
1 similar comment
|
retest this please |
2 participants
Using google-java-format IntelliJ plugin , autoformated storm-webapp module