Skip to content

[STORM-2510] update checkstyle configuration to lower violations #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asfgit merged 4 commits into from
May 15, 2017
Merged

[STORM-2510] update checkstyle configuration to lower violations #2112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88cf6f7
[STORM-2510] commit original unmodified google_checks.xml from checks…
erikdw May 12, 2017
29c7619
[STORM-2510] update checkstyle configuration to lower violations
erikdw May 12, 2017
772c334
[STORM-2510] update line-length limit to 140 from 120 (originally 100…
erikdw May 12, 2017
b8d0402
[STORM-2510] updated maxAllowedViolations after increasing line-lengt…
erikdw May 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/storm-elasticsearch-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>235</maxAllowedViolations>
<maxAllowedViolations>20</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-hbase-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>324</maxAllowedViolations>
<maxAllowedViolations>55</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-hdfs-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>557</maxAllowedViolations>
<maxAllowedViolations>224</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-hive-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>543</maxAllowedViolations>
<maxAllowedViolations>67</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-jdbc-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>188</maxAllowedViolations>
<maxAllowedViolations>36</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-jms-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>197</maxAllowedViolations>
<maxAllowedViolations>78</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-kafka-client-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>67</maxAllowedViolations>
<maxAllowedViolations>2</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-kafka-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>190</maxAllowedViolations>
<maxAllowedViolations>26</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-mongodb-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>349</maxAllowedViolations>
<maxAllowedViolations>38</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-mqtt-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>82</maxAllowedViolations>
<maxAllowedViolations>16</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-opentsdb-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>147</maxAllowedViolations>
<maxAllowedViolations>18</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-perf/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>1179</maxAllowedViolations>
<maxAllowedViolations>207</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-pmml-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>232</maxAllowedViolations>
<maxAllowedViolations>17</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-redis-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>650</maxAllowedViolations>
<maxAllowedViolations>54</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-rocketmq-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>143</maxAllowedViolations>
<maxAllowedViolations>23</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-solr-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>267</maxAllowedViolations>
<maxAllowedViolations>47</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-starter/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>3064</maxAllowedViolations>
<maxAllowedViolations>1538</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-cassandra/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>2764</maxAllowedViolations>
<maxAllowedViolations>577</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-druid/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>193</maxAllowedViolations>
<maxAllowedViolations>29</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-elasticsearch/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>792</maxAllowedViolations>
<maxAllowedViolations>64</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-eventhubs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>1156</maxAllowedViolations>
<maxAllowedViolations>1764</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-hbase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>1572</maxAllowedViolations>
<maxAllowedViolations>370</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-hdfs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>3370</maxAllowedViolations>
<maxAllowedViolations>2220</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-hive/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>1350</maxAllowedViolations>
<maxAllowedViolations>259</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-jdbc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>862</maxAllowedViolations>
<maxAllowedViolations>149</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-jms/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>941</maxAllowedViolations>
<maxAllowedViolations>273</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-kafka-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>2439</maxAllowedViolations>
<maxAllowedViolations>338</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-kafka-monitor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>735</maxAllowedViolations>
<maxAllowedViolations>178</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-kafka/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>2727</maxAllowedViolations>
<maxAllowedViolations>557</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-kinesis/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>1118</maxAllowedViolations>
<maxAllowedViolations>185</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-metrics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>87</maxAllowedViolations>
<maxAllowedViolations>32</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-mongodb/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>665</maxAllowedViolations>
<maxAllowedViolations>96</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-mqtt/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>808</maxAllowedViolations>
<maxAllowedViolations>158</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-opentsdb/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>541</maxAllowedViolations>
<maxAllowedViolations>94</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-pmml/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<!--Note - the version would be inherited-->
<configuration>

<maxAllowedViolations>373</maxAllowedViolations>
<maxAllowedViolations>65</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-redis/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>2041</maxAllowedViolations>
<maxAllowedViolations>598</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-rocketmq/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>705</maxAllowedViolations>
<maxAllowedViolations>100</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-solr/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>781</maxAllowedViolations>
<maxAllowedViolations>108</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion flux/flux-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>1568</maxAllowedViolations>
<maxAllowedViolations>285</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 1 addition & 1 deletion flux/flux-wrappers/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>479</maxAllowedViolations>
<maxAllowedViolations>38</maxAllowedViolations>
</configuration>
</plugin>
</plugins>
Expand Down
13 changes: 11 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,14 +1092,23 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<!-- If you change this, you should also update the storm_checkstyle.xml file to be
based on the google_checks.xml from the version of checkstyle you are choosing. -->
<version>7.7</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>validate</id>
<phase>validate</phase>
<configuration>
<configLocation>google_checks.xml</configLocation>
<configLocation>storm-buildtools/storm_checkstyle.xml</configLocation>
<encoding>UTF-8</encoding>
<failOnViolation></failOnViolation>
<failOnViolation>true</failOnViolation>
<logViolationsToConsole>false</logViolationsToConsole>
<outputFile></outputFile>
<violationSeverity>warning</violationSeverity>
Expand Down
2 changes: 1 addition & 1 deletion sql/storm-sql-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<!--Note - the version would be inherited-->
<configuration>
<maxAllowedViolations>1217</maxAllowedViolations>
<maxAllowedViolations>1283</maxAllowedViolations>
</configuration>
</plugin>
<plugin>
Expand Down
Loading