STORM-2500: remove call to waitUntilReady #2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
@ZacharyThomas Could you let me know your Apache JIRA ID? Thanks in advance! |
Author
|
@HeartSaVioR Thanks for the merge. My username on jira should be actking. Sorry I couldn't find anywhere to set assignee on Jira. |
Contributor
|
@ZacharyThomas Just updated. Thanks again for contributing! |
Author
|
@HeartSaVioR It was fun. Encountered this while trying to debug the exclamation topology dying on a new cluster (see: https://mail-archives.apache.org/mod_mbox/storm-user/201708.mbox/%3CCA%2BAmaO0oP5imSgs7nXboM_VQva0PzoQNGGURG%2BfR3rySystm1g%40mail.gmail.com%3E) Which, if you have any suggestions for, that'd be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.1.x PacemakerClient was refactored so waitUntilReady was private, and called by the send method. But this clojure reference remained, causing pacemaker to fail to initialize. AFAIK this reference can simply be removed, as waitForReady is called on send. However, I'm not very familiar with the code base. I applied this patch to our own cluster with success.