Skip to content

STORM-2696: fix not poll bug when use manual commit #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pczb wants to merge 1 commit into from
Closed

STORM-2696: fix not poll bug when use manual commit #2286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ private boolean poll() {
//Accounting for retriable tuples this way still guarantees that the limit is followed on a per partition basis,
//and prevents locking up the spout when there are too many retriable tuples
&& (numUncommittedOffsets - readyMessageCount < maxUncommittedOffsets
|| consumerAutoCommitMode);
|| consumerAutoCommitMode || readyMessageCount >= maxUncommittedOffsets);

if (!poll) {
if (waitingToEmit()) {
Expand Down