STORM-2974: Add transactional non-opaque spout to storm-kafka-client #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have tested the non-opaque spout by running the storm-kafka-client-examples topology, so testing hasn't been very extensive. |
Contributor
|
@srdo |
Contributor
Author
|
@HeartSaVioR Rebased. |
HeartSaVioR
approved these changes
Jul 13, 2018
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
I should say, thanks for your patience. More than 3 months passed by and we haven't reviewed in time.
I would be +1.
Contributor
|
I have found that couple of public classes are renamed, but they're in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/STORM-2974
The changes outside the Trident package are because I'd like us to start using https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java for testing instead of our own mockito mocks. In order to do that we have to refer to the Consumer interface instead of KafkaConsumer. The replacement is a breaking change in a few places. I'm not expecting this to go on 1.x, and backward compatibility was already broken in #2300, so I haven't done any work to provide a smooth transition.
I've tried to follow the transactional spout in storm-kafka to implement this as much as possible.
There are a couple of followup tasks for this that I'll try to get done later, namely https://issues.apache.org/jira/browse/STORM-2990 and https://issues.apache.org/jira/browse/STORM-2991.