Prevent Nimbus from hanging if random data is sent to nimbus thrift port #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if random data is sent to Nimbus' thrift port, it will result in the following error, causing Nimbus to hang:
java.lang.OutOfMemoryError: Java heap spaceSituations where this can happen:
ssh nimbus -p 6627)telnet nimbus 6627)The solution is to set a limit on the size of the buffers Thrift uses for reading messages. With this fix in place when any of the above occurs, the following will appear in the nimbus log (but nimbus will not hang or crash):