Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-3850] Remove PMD exceptions #3467

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bipinprasad
Copy link
Contributor

What is the purpose of the change

mvn build creates a large number of repeated WARNING messages

Static Code Analyzer (using PMD plugin) reports a large number of errors.

Many of them are parsing errors by PMD plugin itself. This appears to be because the parse is assuming that the target source is below JDK 1.6.

(1) Fix this to assume JDK 1.8 source so that method references are properly parsed.
(2) Fix the java code to remove PMD warnings

Changing the code to 1.8 may reveal new PMC exceptions that were hidden because of PMD plugin parser errors.

(3) Fix new java code PMD errors uncovered when target jdk is switched to jdk8 and even jdk11

How was the change tested

Build and unit test

# Conflicts:
#	external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsConfigTest.java
#	external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBoltTest.java
#	storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java
#	storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java
#	storm-client/src/jvm/org/apache/storm/utils/Utils.java
#	storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestConstraintSolverStrategy.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants