[STORM-1111] - Fix Validation for lots of different configs #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
unrelated kafka messaging test failed in travis |
Contributor
There was a problem hiding this comment.
This should actually not be deprecated. It says zmq, but it is not ZMQ. It should probably be renamed, but that is a follow on JIRA.
Contributor
Author
There was a problem hiding this comment.
will remove deprecated annotation
Contributor
|
Just two minor nits and then I am +1 on this. |
Contributor
Author
|
@revans2 thanks for your review! I have modified the PR to address your comments |
Contributor
There was a problem hiding this comment.
@jerrypeng It should be "key: parallelism.hint".
Contributor
Author
|
@HeartSaVioR thanks for your review. I just modified the PR to address your comments |
Contributor
|
@jerrypeng Nice, +1. |
ppoulosk
pushed a commit
to ppoulosk/storm
that referenced
this pull request
Nov 17, 2016
two implementations, one that will load from a local file, and another that will load a config from artifactory. Merge pull request apache#807 from ppoulosk/YSTORM-3095-redux [YSTORM-3095] [YSTORM-3779] Re-merge and fix Artifactory scheduler plugins Move to org.apache
ppoulosk
pushed a commit
to ppoulosk/storm
that referenced
this pull request
Mar 30, 2017
two implementations, one that will load from a local file, and another that will load a config from artifactory. Merge pull request apache#807 from ppoulosk/YSTORM-3095-redux [YSTORM-3095] [YSTORM-3779] Re-merge and fix Artifactory scheduler plugins Move to org.apache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.