fix: make data retrieval of IOLink sensor more robust #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java
dominikriemer
requested changes
Oct 13, 2023
| collector.collect(parsedEvent); | ||
| try { | ||
| var portResult = getMap(payload, | ||
| "/iolinkmaster/port[%s]/iolinkdevice/pdin".formatted(ports.get(i))); |
There was a problem hiding this comment.
Can we check if the port exists here before fetching it?
| try { | ||
| var portResult = getMap(payload, | ||
| "/iolinkmaster/port[%s]/iolinkdevice/pdin".formatted(ports.get(i))); | ||
| var eventData = (String) portResult.get("data"); |
There was a problem hiding this comment.
same here for portResult
dominikriemer
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes the data retrieval within the IOLink adapter more robust. Prior to it, an error occurring for one port stopped the processing of all subsequent ports. This means, that in case the processing fails for port 2, e.g., since this port is not connected to a sensor and therefore does not deliver any data, parsing for port 3 and 4 is skipped.
From now on, only the affected port will be skipped.
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no