Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-3714 Deprecate and repackage common APIs part 6 #1085

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Oct 17, 2024

WW-3714

This PR deprecates and provides repackaged replacements for the following APIs, ahead of their permanent migration in Struts 7.0:

  • com.opensymphony.xwork2.interceptor.AliasInterceptor
  • com.opensymphony.xwork2.interceptor.ChainingInterceptor
  • com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor
  • com.opensymphony.xwork2.interceptor.DefaultWorkflowInterceptor
  • com.opensymphony.xwork2.interceptor.ExceptionMappingInterceptor
  • com.opensymphony.xwork2.interceptor.LoggingInterceptor
  • com.opensymphony.xwork2.interceptor.ModelDrivenInterceptor
  • com.opensymphony.xwork2.interceptor.ParameterRemoverInterceptor
  • com.opensymphony.xwork2.interceptor.PrepareInterceptor
  • com.opensymphony.xwork2.interceptor.ScopedModelDrivenInterceptor
  • com.opensymphony.xwork2.interceptor.StaticParametersInterceptor

Similar to #1084, the interceptor implementations were necessarily duplicated to ensure complete overriding compatibility with the old interceptor types, whilst allowing the new interceptors to extend the new variants of AbstractInterceptor and MethodFilterInterceptor (as they would be in Struts 7.0).

This PR additional modifies the following abstract class to enable overriding without importing com.opensymphony.xwork2.ActionInvocation:

  • org.apache.struts2.result.StrutsResultSupport

@kusalk kusalk changed the title WW-3714 Deprecate and repackage common APIs part 5 WW-3714 Deprecate and repackage common APIs part 6 Oct 17, 2024
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from a6c4b52 to 7b212c4 Compare October 17, 2024 08:27
@kusalk kusalk force-pushed the kusal-depr-apis-6 branch 2 times, most recently from f908a32 to 717046f Compare October 17, 2024 08:36
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from 7b212c4 to 1b86f8d Compare October 17, 2024 08:37
@kusalk kusalk force-pushed the kusal-depr-apis-6 branch from 717046f to f8dc1ce Compare October 17, 2024 09:10
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from 1b86f8d to 440153c Compare October 17, 2024 09:10
@kusalk kusalk force-pushed the kusal-depr-apis-6 branch from f8dc1ce to a874416 Compare October 17, 2024 09:29
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from 440153c to c91e032 Compare October 17, 2024 09:30
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from 9e60587 to 8ff8d18 Compare October 22, 2024 00:32
@kusalk kusalk force-pushed the kusal-depr-apis-6 branch from 1032783 to 1dea3d3 Compare October 22, 2024 02:56
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from 8ff8d18 to 18f85c5 Compare October 22, 2024 02:56
@kusalk kusalk force-pushed the kusal-depr-apis-6 branch from 1dea3d3 to 228d33e Compare October 22, 2024 05:55
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from 18f85c5 to 7c664c0 Compare October 22, 2024 05:56
@kusalk kusalk force-pushed the kusal-depr-apis-6 branch from 228d33e to deb6c09 Compare October 22, 2024 06:02
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from 7c664c0 to cdb7088 Compare October 22, 2024 06:05
@kusalk kusalk marked this pull request as ready for review October 22, 2024 07:08
@kusalk kusalk force-pushed the kusal-depr-apis-7 branch from cdb7088 to 2432449 Compare October 22, 2024 07:51
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.3% Coverage on New Code (required ≥ 80%)
27.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@kusalk kusalk requested a review from lukaszlenart October 22, 2024 12:11
Base automatically changed from kusal-depr-apis-6 to master October 23, 2024 10:12
@kusalk kusalk merged commit 89bcbec into master Oct 25, 2024
8 of 9 checks passed
@kusalk kusalk deleted the kusal-depr-apis-7 branch October 25, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants