Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-3952: Credit card validator #130

Merged
merged 7 commits into from
Apr 24, 2017
Merged

WW-3952: Credit card validator #130

merged 7 commits into from
Apr 24, 2017

Conversation

lukaszlenart
Copy link
Member

Implements a credit card validator
WW-3952

@lukaszlenart
Copy link
Member Author

This is ready for review

@cnenning
Copy link
Member

I hope the regex is stable 😉

@lukaszlenart
Copy link
Member Author

I hope the regex is stable

What do you mean by that? I have used this http://www.regular-expressions.info/creditcard.html

@cnenning
Copy link
Member

How often do credit card companies change their number-patterns in a way that the regex needs to be updated? 'guess it is rare enough.

@lukaszlenart
Copy link
Member Author

Good question... I have used those random card numbers in tests and looks ok (but we will see) https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm

@cnenning
Copy link
Member

If patterns change users have another reason to upgrade to latest struts 😆

@gregh3269
Copy link
Contributor

Last time I did some credit card validation, I needed to use a java script version as the payment process obscured the field names by not having the "name" attribute (so it was not obvious when these were sent over https) and I was unable to do server side validation.

@asfgit asfgit merged commit 6ef9f7a into apache:master Apr 24, 2017
@lukaszlenart lukaszlenart deleted the credit-card-validations branch May 18, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants