WW-4818 change default Multipart validation regex to comply with RFC1341 #151
Conversation
| @@ -88,7 +88,7 @@ | |||
| */ | |||
| public static final String REQUEST_POST_METHOD = "POST"; | |||
|
|
|||
| public static final String MULTIPART_FORM_DATA_REGEX = "^multipart\\/form-data(; boundary=[\\-a-zA-Z0-9]{1,70})?"; | |||
| public static final String MULTIPART_FORM_DATA_REGEX = "^multipart/form-data(; boundary=[0-9a-zA-Z'()+_,\\-./:=?]{1,70})?"; | |||
There was a problem hiding this comment.
You have to escape . as it now means Any single character
There was a problem hiding this comment.
Also - has to be escaped as it is treated as a group separator
There was a problem hiding this comment.
not within the square brackets according to my knowledge
There was a problem hiding this comment.
you are correct about the - needing to be escaped , but that's the only one i escaped. (they're in the order they're mentioned in RFC1341 (so i moved the - backwards in the pattern)
There was a problem hiding this comment.
There are two test cases that you can extend or another one - see DispatcherTest
There was a problem hiding this comment.
Ok, i'll add some tests to confirm the pattern is correct.
(Or if needed to correct it)
|
@lukaszlenart
Please feel free to tell me what other test-cases you want added. |
|
Looks good 👍 LGTM :) |
|
@lukaszlenart |
No description provided.