WW-4877: adds missing header with license #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdutry
reviewed
Oct 21, 2017
| employee.id.required=ID mu� angegeben werden | ||
| employee.lastName.required=Nachname wird ben�tigt | ||
| employee.birthDate.required=Geburtsdatum wird ben�tigt | ||
| employee.backtolist=Zur�ck zur Mitarbeiterliste |
There was a problem hiding this comment.
Did the encoding of this file change?
Does it still show the translations correctly when running the application?
There was a problem hiding this comment.
Good catch, fixed :)
| skill=Kenntnis | ||
| skill.name=Name | ||
| skill.description=Beschreibung | ||
|
|
||
| skill.name.required=Name muss angegeben werden | ||
| skill.backtolist=Zur�ck zur Kenntnis Liste | ||
| skill.backtolist=Zur�ck zur Kenntnis Liste |
There was a problem hiding this comment.
same as before, encoding change?
| @@ -29,9 +26,6 @@ | |||
| import javax.servlet.http.HttpServletRequest; | |||
| import javax.servlet.http.HttpServletResponse; | |||
|
|
|||
| /** | |||
| * @see Anchor | |||
There was a problem hiding this comment.
Is this javadoc reference no longer relevant?
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="ISO-8859-1"?> | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; | ||
|
|
||
| import javax.servlet.ServletInputStream; | ||
| import javax.servlet.http.HttpServlet; |
| jsp.error.tagfile.nameNotUnique= | ||
| jsp.error.tagfile.nameFrom.noAttribute= | ||
| jsp.error.tagfile.nameFrom.badAttribute= | ||
| jsp.error.useBean.noSession=Il est ill�gal pour useBean d''utiliser une port�e de session (session scope) quand la page JSP indique (via la directive de page) qu''elle ne participe pas aux sessions | ||
| jsp.error.useBean.noSession=Il est ill�gal pour useBean d''utiliser une port�e de session (session scope) quand la page JSP indique (via la directive de page) qu''elle ne participe pas aux sessions |
There was a problem hiding this comment.
did the encoding of this file change? does it still show correctly?
| import org.osgi.framework.Bundle; | ||
| import org.osgi.framework.BundleContext; | ||
|
|
||
| import javax.servlet.ServletContext; | ||
| import java.util.List; |
| @@ -20,9 +18,6 @@ | |||
| */ | |||
| package org.apache.struts2.oval.interceptor; | |||
|
|
|||
| import net.sf.oval.constraint.NotNull; | |||
| import net.sf.oval.constraint.NotEmpty; | |||
| import net.sf.oval.constraint.Length; | |||
| import com.opensymphony.module.sitemesh.DecoratorMapper; | ||
| import com.opensymphony.sitemesh.DecoratorSelector; | ||
| import com.opensymphony.sitemesh.Content; | ||
| import com.opensymphony.sitemesh.SiteMeshContext; | ||
| import com.opensymphony.sitemesh.compatability.Content2HTMLPage; | ||
| import com.opensymphony.sitemesh.compatability.OldDecorator2NewDecorator; |
| import com.opensymphony.module.sitemesh.DecoratorMapper; | ||
| import com.opensymphony.sitemesh.DecoratorSelector; | ||
| import com.opensymphony.sitemesh.Content; | ||
| import com.opensymphony.sitemesh.SiteMeshContext; | ||
| import com.opensymphony.sitemesh.compatability.Content2HTMLPage; | ||
| import com.opensymphony.sitemesh.compatability.OldDecorator2NewDecorator; |
|
LGTM 💯 |
|
Great .... let it be ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each file must have a header with license see. Also this PR will enable checking missing headers on each build.
Resolves WW-4877 #