WW-5341 Ensure exclusion list applies to objects from all ClassLoaders #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e excluded classes as Strings
|
Kudos, SonarCloud Quality Gate passed! |
kusalk
commented
Aug 30, 2023
| @@ -84,16 +86,17 @@ public Object setup(Map context, Object target, Member member, String propertyNa | |||
|
|
|||
| @Override | |||
| public void restore(Map context, Object target, Member member, String propertyName, Object state) { | |||
| if (state != null) { | |||
| final AccessibleObject accessible = (AccessibleObject) member; | |||
| final boolean stateBoolean = ((Boolean) state).booleanValue(); // Using twice (avoid unboxing) | |||
There was a problem hiding this comment.
Not sure what this comment meant but don't think my refactor has broken anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5341
In applications where there are multiple classloaders, it may be possible for
SecurityMemberAccessto obtain a false negative if the classloader used to load the target object was different to the one used to load the exclusion list.To rectify this, we use String comparison of the class name instead. We still use the default classloader to validate the exclusion list on application start. A future enhancement might be to make the validating classloader configurable.