Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-5342 Add option to block use of default package #742

Merged
merged 3 commits into from
Sep 26, 2023
Merged

WW-5342 Add option to block use of default package #742

merged 3 commits into from
Sep 26, 2023

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Aug 30, 2023

@kusalk kusalk changed the title WW-5342 Ban use of default package WW-5342 Add option to block use of default package Aug 30, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

78.7% 78.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Base automatically changed from WW-5341-classloaders to master September 26, 2023 08:07
@lukaszlenart
Copy link
Member

Is it still in-progress?

@kusalk kusalk marked this pull request as ready for review September 26, 2023 08:09
@kusalk
Copy link
Member Author

kusalk commented Sep 26, 2023

@lukaszlenart It's ready for review - I left it in draft status until the base branch was merged :)

lukaszlenart
lukaszlenart approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukaszlenart lukaszlenart merged commit bb83a60 into master Sep 26, 2023
@lukaszlenart lukaszlenart deleted the WW-5342-default-package branch September 26, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszlenart lukaszlenart lukaszlenart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kusalk @lukaszlenart