Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WW-5362] Removes type attribute out of <s:script/> tag #812

Merged
merged 3 commits into from
Jan 1, 2024
Merged

[WW-5362] Removes type attribute out of <s:script/> tag #812

merged 3 commits into from
Jan 1, 2024
+139 −139

Conversation

lukaszlenart
Copy link
Member

Closes WW-5362

@lukaszlenart
Copy link
Member Author

FYI @sepe81 @gregh3269

@gregh3269
Copy link
Contributor

Seems now I get
SEVERE: Exception sending context initialized event to listener instance of class [org.apache.struts2.tiles.StrutsTilesListener]
java.lang.NoClassDefFoundError: org/apache/commons/digester3/Rule
Caused by: java.lang.ClassNotFoundException: org.apache.commons.digester3.Rule
Deps want commons-digester-2.1.jar think this is v3?

@lukaszlenart
Copy link
Member Author

What app have you used? This change shouldn't affect Digester

@gregh3269
Copy link
Contributor

gregh3269 commented Dec 18, 2023 •
edited
Loading

My app.

@lukaszlenart
Copy link
Member Author

This is related to WW-5347 - and you are using 6.3.0.1 version as far I see, changes in this PR are unrelated to your problem.

@lukaszlenart
Copy link
Member Author

@gregh3269 can we discuss this in the dev@ email list?

@gregh3269
Copy link
Contributor

OK, mailing list.

...although I got it working and it seems good.

@lukaszlenart @sepe81
WW-5362 Removes language attribute
80038f0 
Co-authored-by: Sebastian Peters <sebastian.peters@gmail.com>
@lukaszlenart lukaszlenart requested a review from sepe81 December 18, 2023 17:54
@lukaszlenart
Copy link
Member Author

Are we good here?

sepe81
sepe81 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@sepe81 sepe81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after cleanup for ww-template-autoexport.html

core/src/site/confluence/ww-template-autoexport.html Outdated Show resolved Hide resolved
@lukaszlenart @sepe81
WW-5362 Removes deprecated language attribute
b9c797e 
Co-authored-by: Sebastian Peters <sebastian.peters@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lukaszlenart lukaszlenart merged commit 3dabcf1 into master Jan 1, 2024
8 of 9 checks passed
@lukaszlenart lukaszlenart deleted the feature/WW-5362-remove-type branch January 1, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepe81 sepe81 sepe81 approved these changes

@rgielen rgielen Awaiting requested review from rgielen

@aleksandr-m aleksandr-m Awaiting requested review from aleksandr-m

@yasserzamani yasserzamani Awaiting requested review from yasserzamani

@sdutry sdutry Awaiting requested review from sdutry

@cnenning cnenning Awaiting requested review from cnenning

@kusalk kusalk Awaiting requested review from kusalk

Assignees
No one assigned
Labels
Lazy Consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszlenart @gregh3269 @sepe81