-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small spelling and MD fixes (IntelliJ assisted) #854
Small spelling and MD fixes (IntelliJ assisted) #854
Conversation
SECURITY.md
Outdated
and what potential vulnerability it can have: | ||
|
||
| Version | Supported | | ||
| ------- | ------------------ | | ||
|---------|--------------------| | ||
| 6.0.0 | :white_check_mark: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it would be more consistent to mention just the maintenance branches (e.g., 6.x and 2.5.x) instead of specific versions that need permanent updates to this table?
@lukaszlenart I could add another commit if you find this valuable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, make sense. We have the release page with detailed info as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@lukaszlenart Would it be possible to skip the "SonarCloud / Scan (pull_request)" for PR builds from forks to avoid: Error: Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.10.0.2594:sonar (default-cli) on project struts2-parent: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator -> [Help 1] I guess it could be done under .github/workflows/sonar.yml but have no experience with github workflow config. |
eb66308
to
644bd1f
Compare
Sure, I will try to do it |
This should solve the problem #862 |
No description provided.