Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small spelling and MD fixes (IntelliJ assisted) #854

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

sepe81
Copy link
Contributor

@sepe81 sepe81 commented Jan 21, 2024

No description provided.

SECURITY.md Outdated
and what potential vulnerability it can have:

| Version | Supported |
| ------- | ------------------ |
|---------|--------------------|
| 6.0.0 | :white_check_mark: |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it would be more consistent to mention just the maintenance branches (e.g., 6.x and 2.5.x) instead of specific versions that need permanent updates to this table?

@lukaszlenart I could add another commit if you find this valuable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, make sense. We have the release page with detailed info as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sepe81
Copy link
Contributor Author

sepe81 commented Jan 24, 2024

@lukaszlenart Would it be possible to skip the "SonarCloud / Scan (pull_request)" for PR builds from forks to avoid:

Error: Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.10.0.2594:sonar (default-cli) on project struts2-parent: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator -> [Help 1]

I guess it could be done under .github/workflows/sonar.yml but have no experience with github workflow config.
Maybe check for the existence of SONAR_TOKEN?

@sepe81 sepe81 force-pushed the feature/update-security-policy branch from eb66308 to 644bd1f Compare January 24, 2024 14:14
@lukaszlenart
Copy link
Member

Sure, I will try to do it

@lukaszlenart
Copy link
Member

This should solve the problem #862

@lukaszlenart lukaszlenart merged commit 7843cd5 into apache:master Jan 24, 2024
6 of 7 checks passed
@sepe81 sepe81 deleted the feature/update-security-policy branch January 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants