[WW-5388] Fixes a few issues in Servlet 6 file upload usage #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszlenart
requested review from
rgielen,
aleksandr-m,
yasserzamani,
sdutry and
kusalk
|
//cc: @burtonrhodes |
lukaszlenart
force-pushed
the
fix/WW-5388-fileupload
branch
from
93acbe8
to
91436a1
Compare
- removes duplicated validation messages where both interceptors have been used - defines a proper error message on a general file upload exception - removes generic definition in tests
lukaszlenart
force-pushed
the
fix/WW-5388-fileupload
branch
from
91436a1
to
f913c40
Compare
|
|
@lukaszlenart Thanks for all your work here. Limited testing on my dev machine looks good. I have uploaded this patch to a subset our server cluster and will report back with any issues I see. |
|
Are we good here? |
|
@lukaszlenart Everything here seems to working well on my end. This gets my approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow ups #861
Refs WW-5388