-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WW-5417 bump ognl version to fix security issue #915
WW-5417 bump ognl version to fix security issue #915
Conversation
pom.xml
Outdated
@@ -112,7 +112,7 @@ | |||
<asm.version>9.6</asm.version> | |||
<jackson.version>2.16.1</jackson.version> | |||
<log4j2.version>2.23.1</log4j2.version> | |||
<ognl.version>3.3.4</ognl.version> | |||
<ognl.version>3.3.4-atlassian-1</ognl.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be replaced with 3.3.5 once released OGNL patch PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try you to use 3.3.5 verision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks
} | ||
|
||
|
||
public static class HolderWithPublicField { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukaszlenart This is a PoC of the original public field bug I reported
} | ||
} | ||
|
||
public static class HolderWhoseFieldWithPublicSetterDifferentFieldName { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukaszlenart This is a PoC of the new public setter bug discovered by @jefferyxhy
Remaining tests are variations for full coverage and to prevent regressions |
The builds are failing as the Atlassian forked release is not on the Central repo, it is only available on our repo. |
@@ -112,7 +112,7 @@ | |||
<asm.version>9.6</asm.version> | |||
<jackson.version>2.16.1</jackson.version> | |||
<log4j2.version>2.23.1</log4j2.version> | |||
<ognl.version>3.3.4</ognl.version> | |||
<ognl.version>3.3.5</ognl.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukaszlenart updated with 3.3.5. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
WW-5417
bump the Ognl version to fix the security issue that
ObjectPropertyAccessor#setPossibleProperty
bypass SecurityMemberAccess right check.*********************** From Ognl PR ***********************
OgnlRuntime.setFieldValue
doesn't check member access rights viaMemberAccess
interfaceReason
getMethodValue
/setMethodValue
/getFieldValue
are all updated with member access rights check but notsetFieldValue
, which causeObjectPropertyAccessor#setPossibleProperty
expose to security vuln.ObjectPropertyAccessor#setPossibleProperty
has a fallback mechanism usinggetWriteMethod
which also lack member access rights checkChanges/ Solution
OgnlRuntime#setFieldValue
that is controlled by parametercheckAccessAndExistence
ObjectPropertyAccessor#setPossibleProperty
code block that usesOgnlRuntime#getWriteMethod
Result & Impact
now
ObjectPropertyAccessor#setPossibleProperty
will also check member access rights when fallback to use: