Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-5418 Forbid Enums and Jasper classes #916

Merged
merged 2 commits into from
Apr 20, 2024
Merged

WW-5418 Forbid Enums and Jasper classes #916

merged 2 commits into from
Apr 20, 2024

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Apr 18, 2024

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kusalk kusalk marked this pull request as ready for review April 18, 2024 01:27
lukaszlenart
lukaszlenart reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a breaking change?

@kusalk
Copy link
Member Author

kusalk commented Apr 19, 2024

It is indeed - but I think the security benefits should come first in this scenario

@kusalk kusalk merged commit 3c21e82 into master Apr 20, 2024
9 checks passed
@kusalk kusalk deleted the WW-5418-struts-sec branch April 20, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszlenart lukaszlenart lukaszlenart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kusalk @lukaszlenart