WW-5414 Always call afterInvocation even in case of exception #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszlenart
requested review from
rgielen,
aleksandr-m,
yasserzamani,
sdutry,
cnenning and
kusalk
asfgit
force-pushed
the
feature/WW-5414-after
branch
from
0141068 to
32f9b68
Compare
kusalk
reviewed
May 11, 2024
| try { | ||
| afterInvocation(); | ||
| } catch (Exception ex) { | ||
| exception = ex; |
There was a problem hiding this comment.
Hmm what if beforeInvocation() already threw an exception, do we want to overwrite that?
There was a problem hiding this comment.
Yeah, I know, I thought about adding additional afterException and maybe beforeException fields to keep this information
There was a problem hiding this comment.
If we're only going to record one, the first one is probably more relevant - I'll let you make the call
There was a problem hiding this comment.
Right, let's keep it simple, I will set exception only if wasn't already set
kusalk
approved these changes
May 11, 2024
asfgit
force-pushed
the
feature/WW-5414-after
branch
from
32f9b68 to
7c271f6
Compare
asfgit
force-pushed
the
feature/WW-5414-after
branch
from
7c271f6 to
4dfbe09
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close WW-5414