add tooltip to control

apache · Jan 10, 2021 · 033a485 · 033a485
1 parent 2aa59c1
commit 033a485
Showing 1 changed file with 17 additions and 11 deletions.
diff --git a/superset-frontend/src/explore/components/AdhocMetricOption.jsx b/superset-frontend/src/explore/components/AdhocMetricOption.jsx
@@ -18,6 +18,7 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
+import { Tooltip } from 'src/common/components/Tooltip';
 import AdhocMetric from '../AdhocMetric';
 import columnType from '../propTypes/columnType';
 import savedMetricType from '../propTypes/savedMetricType';
@@ -70,17 +71,22 @@ class AdhocMetricOption extends React.PureComponent {
  savedMetric={savedMetric}
  datasourceType={datasourceType}
  >
- <DraggableOptionControlLabel
- savedMetric={savedMetric}
- label={adhocMetric.label}
- onRemove={this.onRemoveMetric}
- onMoveLabel={onMoveLabel}
- onDropLabel={onDropLabel}
- index={index}
- type={OPTION_TYPES.metric}
- isAdhoc
- isFunction
- />
+ <Tooltip
+ placement="top"
+ title={savedMetric.expression || adhocMetric.label}
+ >
+ <DraggableOptionControlLabel
+ savedMetric={savedMetric}
+ label={adhocMetric.label}
+ onRemove={this.onRemoveMetric}
+ onMoveLabel={onMoveLabel}
+ onDropLabel={onDropLabel}
+ index={index}
+ type={OPTION_TYPES.metric}
+ isAdhoc
+ isFunction
+ />
+ </Tooltip>
  </AdhocMetricPopoverTrigger>
  );
  }