Merge pull request #22 from lyft/mergeDevelop

start sp8: merge lyft-develop to lyft-master for staging

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,47 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+A clear and concise description of what the bug is.
+
+### Expected results
+
+what you expected to happen.
+
+### Actual results
+
+what actually happens.
+
+#### Screenshots
+
+If applicable, add screenshots to help explain your problem.
+
+#### How to reproduce the bug
+
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+### Environment
+
+(please complete the following information):
+
+- superset version: [e.g. `v0.29`, `master`, `commit`]
+- python version: `python --version`
+- node.js version: `node -v`
+- npm version: `npm -v`
+
+### Checklist
+
+Make sure these boxes are checked before submitting your issue - thank you!
+
+- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
+- [ ] I have reproduced the issue with at least the latest released version of superset.
+- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
+
+### Additional context
+
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,17 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/sip.md

@@ -0,0 +1,31 @@
+---
+name: SIP
+about: Superset Improvement Proposal
+
+---
+
+## [SIP] Proposal for XXX
+
+### Motivation
+
+Description of the problem to be solved.
+
+### Proposed Change
+
+Describe how the feature will be implemented, or the problem will be solved. If possible, include mocks, screenshots, or screencasts (even if from different tools).
+
+### New or Changed Public Interfaces
+
+Describe any new additions to the model, views or `REST` endpoints. Describe any changes to existing visualizations, dashboards and React components. Describe changes that affect the Superset CLI and how Superset is deployed.
+
+### New dependencies
+
+Describe any `npm`/`PyPI` packages that are required. Are they actively maintained? What are their licenses?
+
+### Migration Plan and Compatibility
+
+Describe any database migrations that are necessary, or updates to stored URLs.
+
+### Rejected Alternatives
+
+Describe alternative approaches that were considered and rejected.

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,31 @@
+### CATEGORY
+
+Choose one
+
+- [ ] Bug Fix
+- [ ] Enhancement (new features, refinement)
+- [ ] Refactor
+- [ ] Add tests
+- [ ] Build / Development Environment
+- [ ] Documentation
+
+### SUMMARY
+<!--- Describe the change below, including rationale and design decisions -->
+
+### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
+<!--- Skip this if not applicable -->
+
+### TEST PLAN
+<!--- What steps should be taken to verify the changes -->
+
+### ADDITIONAL INFORMATION
+<!--- Check any relevant boxes with "x" -->
+<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
+- [ ] Has associated issue:
+- [ ] Changes UI
+- [ ] Requires DB Migration.
+- [ ] Confirm DB Migration upgrade and downgrade tested.
+- [ ] Introduces new feature or API
+- [ ] Removes existing feature or API
+
+### REVIEWERS

.github/config.yml

@@ -0,0 +1,15 @@
+# Configuration for request-info - https://github.com/behaviorbot/request-info
+
+# *Required* Comment to reply with
+requestInfoReplyComment: >
+ We would appreciate it if you could provide us with more info about this issue/pr!
+ Please do not leave the `title` or `description` empty.
+
+# *OPTIONAL* default titles to check against for lack of descriptiveness
+# MUST BE ALL LOWERCASE
+requestInfoDefaultTitles:
+ - update readme.md
+ - updates
+
+# *OPTIONAL* Label to be added to Issues and Pull Requests with insufficient information given
+requestInfoLabelToAdd: "need:more-info"

.github/issue_label_bot.yaml

@@ -0,0 +1,5 @@
+# for Issue Label Bot https://github.com/marketplace/issue-label-bot
+label-alias:
+ bug: '#bug'
+ feature_request: '#enhancement'
+ question: '#question'

.github/move.yml

@@ -0,0 +1,27 @@
+# Configuration for Move Issues - https://github.com/dessant/move-issues
+
+# Delete the command comment when it contains no other content
+deleteCommand: true
+
+# Close the source issue after moving
+closeSourceIssue: true
+
+# Lock the source issue after moving
+lockSourceIssue: false
+
+# Mention issue and comment authors
+mentionAuthors: true
+
+# Preserve mentions in the issue content
+keepContentMentions: false
+
+# Move labels that also exist on the target repository
+moveLabels: true
+
+# Set custom aliases for targets
+# aliases:
+# r: repo
+# or: owner/repo
+
+# Repository to extend settings from
+# _extends: repo

.github/stale.yml

@@ -0,0 +1,19 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 60
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 7
+# Issues with these labels will never be considered stale
+exemptLabels:
+ - "#SIP"
+ - ".pinned"
+ - ".security"
+# Label to use when marking an issue as stale
+staleLabel: inactive
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+ This issue has been automatically marked as stale because it has not had
+ recent activity. It will be closed if no further activity occurs.
+ Thank you for your contributions. For admin, please label this issue `.pinned`
+ to prevent stale bot from closing the issue.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false

.rat-excludes

@@ -38,3 +38,5 @@ searchindex.js
 requirements.txt
 # vendorized
 vendor/*
+# github configuration
+.github/*

.travis.yml

@@ -14,8 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-cache:
- pip: true
 jobs:
  include:
  - language: python

CONTRIBUTING.md

@@ -385,9 +385,6 @@ npm run dev
 
 # Compile the Javascript and CSS in production/optimized mode for official releases
 npm run prod
-
-# Copy a conf file from the frontend to the backend
-npm run sync-backend
 ```
 
 #### Updating NPM packages

LICENSE.txt

@@ -231,5 +231,3 @@ BSD 3-Clause licenses
 ========================================================================
 Creative Commons Attribution 4.0
 ========================================================================
-
- (Creative Commons Attribution 4.0) diva-gis (http://www.diva-gis.org/Data)

RELEASING.md

@@ -51,6 +51,8 @@ git push origin master
 You'll probably want to run these commands manually and understand what
 they do prior to doing so.
 
+## Release setup
+
 First you need to setup a few things. This is a one-off and doesn't
 need to be done at every release.
 
@@ -59,7 +61,10 @@ need to be done at every release.
  gpg --gen-key
 
  # Checkout ASF dist repo
- svn checkout https://dist.apache.org/repos/dist/dev/incubator/superset/ ~/svn/superset
+
+ svn checkout https://dist.apache.org/repos/dist/dev/incubator/superset/ ~/svn/superset_dev
+
+ svn checkout https://dist.apache.org/repos/dist/incubator/superset/ ~/svn/superset
  cd ~/svn/superset
 
 
@@ -72,6 +77,8 @@ need to be done at every release.
  svn commit -m "Add PGP keys of new Superset committer"
 ```
 
+## Crafting tarball and signatures
+
 Now let's craft a source release
 ```bash
  # Assuming these commands are executed from the root of the repo
@@ -87,23 +94,46 @@ Now let's craft a source release
  # Alternatively you could clone the repo into another location as in
  # git clone git@github.com:apache/incubator-superset.git superset-releases
  git clean -fxd
+ # Create the target folder
+ mkdir -p ~/svn/superset_dev/${VERSION}/
  git archive \
  --format=tar.gz ${VERSION} \
  --prefix=apache-superset-${VERSION}/ \
- -o apache-superset-${VERSION}-source.tar.gz
+ -o ~/svn/superset_dev/${VERSION}/apache-superset-${VERSION}-source.tar.gz
 
+ cd ~/svn/superset_dev/
  scripts/sign.sh apache-superset-${VERSION}-source.tar.gz
 ```
 
-Now let's ship this into svn
+## Shipping to SVN
+
+Now let's ship this RC into svn's dev folder
 
 ```bash
  # cp or mv the files over to the svn repo
- mkdir ~/svn/superset/${VERSION}/
- cp apache-superset-${VERSION}* ~/svn/superset/${VERSION}/
+ mkdir ~/svn/superset_dev/${VERSION}/
+ cp apache-superset-${VERSION}* ~/svn/superset_dev/${VERSION}/
+ cd ~/svn/superset_dev/
+ svn add ${VERSION}
+ svn commit
+```
+
+Now you're ready to start the VOTE thread.
+
+## Validating a release
+
+https://www.apache.org/info/verification.html
+
+## Publishing a successful release
+
+Upon a successful vote, you'll have to copy the folder into the non-"dev/"
+folder.
+```bash
+ cp -r ~/svn/superset_dev/${VERSION}/ ~/svn/superset/${VERSION}/
  cd ~/svn/superset/
  svn add ${VERSION}
  svn commit
 ```
 
-Now you're ready to announce the release on the mailing list
+Now you can announce the release on the mailing list, make sure to use the
+proper template