sort set for exceptions list

apache · Mar 1, 2022 · 1d29e9f · 1d29e9f
1 parent 0cdc02d
commit 1d29e9f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/superset/commands/exceptions.py b/superset/commands/exceptions.py
@@ -68,7 +68,7 @@ def add_list(self, exceptions: List[ValidationError]) -> None:
 
  def get_list_classnames(self) -> List[str]:
  return list(
- dict.fromkeys([ex.__class__.__name__ for ex in self._invalid_exceptions])
+ sorted({ ex.__class__.__name__ for ex in self._invalid_exceptions})
  )
 
  def normalized_messages(self) -> Dict[Any, Any]:

diff --git a/tests/integration_tests/databases/commands_tests.py b/tests/integration_tests/databases/commands_tests.py
@@ -83,8 +83,8 @@ def test_create_duplicate_error(self, mock_logger):
  mock_logger.assert_called_with(
  action="db_connection_failed."
  "DatabaseInvalidError."
- "DatabaseRequiredFieldValidationError."
- "DatabaseExistsValidationError"
+ "DatabaseExistsValidationError."
+ "DatabaseRequiredFieldValidationError"
  )
 
  @mock.patch(