lint

apache · Nov 28, 2022 · 1d4dab9 · 1d4dab9
1 parent 2ddc3ae
commit 1d4dab9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/superset/connectors/base/models.py b/superset/connectors/base/models.py
@@ -395,7 +395,7 @@ def data_for_slices( # pylint: disable=too-many-locals
  @staticmethod
  def filter_values_handler( # pylint: disable=too-many-arguments
  values: Optional[FilterValues],
- op: str,
+ operator: str,
  target_generic_type: GenericDataType,
  target_native_type: Optional[str] = None,
  is_list_target: bool = False,
@@ -406,7 +406,7 @@ def filter_values_handler( # pylint: disable=too-many-arguments
  return None
 
  def handle_single_value(value: Optional[FilterValue]) -> Optional[FilterValue]:
- if op == utils.FilterOperator.TEMPORAL_RANGE:
+ if operator == utils.FilterOperator.TEMPORAL_RANGE:
  return value
  if (
  isinstance(value, (float, int))

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -1415,7 +1415,7 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
  target_generic_type = GenericDataType.STRING
  eq = self.filter_values_handler(
  values=val,
- op=op,
+ operator=op,
  target_generic_type=target_generic_type,
  target_native_type=col_type,
  is_list_target=is_list_target,

diff --git a/superset/models/helpers.py b/superset/models/helpers.py
@@ -1095,7 +1095,7 @@ def template_params_dict(self) -> Dict[Any, Any]:
  @staticmethod
  def filter_values_handler( # pylint: disable=too-many-arguments
  values: Optional[FilterValues],
- op: str,
+ operator: str,
  target_generic_type: utils.GenericDataType,
  target_native_type: Optional[str] = None,
  is_list_target: bool = False,
@@ -1108,7 +1108,7 @@ def filter_values_handler( # pylint: disable=too-many-arguments
  return None
 
  def handle_single_value(value: Optional[FilterValue]) -> Optional[FilterValue]:
- if op == utils.FilterOperator.TEMPORAL_RANGE:
+ if operator == utils.FilterOperator.TEMPORAL_RANGE:
  return value
  if (
  isinstance(value, (float, int))
@@ -1695,7 +1695,7 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
  target_generic_type = utils.GenericDataType.STRING
  eq = self.filter_values_handler(
  values=val,
- op=op,
+ operator=op,
  target_generic_type=target_generic_type,
  target_native_type=col_type,
  is_list_target=is_list_target,