Skip to content

Commit

Permalink
fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
hantmac committed Mar 14, 2023
1 parent 1fa7ee5 commit 26581b9
Showing 1 changed file with 2 additions and 18 deletions.
20 changes: 2 additions & 18 deletions tests/unit_tests/db_engine_specs/test_databend.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,6 @@ def test_execute_connection_error() -> None:
DatabendEngineSpec.execute(cursor, "SELECT col1 from table1")


@pytest.mark.parametrize(
"target_type,expected_result",
[
("Date", "to_date('2019-01-02')"),
("DateTime", "to_dateTime('2019-01-02 03:04:05')"),
("UnknownType", None),
],
)
def test_connect_convert_dttm(
target_type: str, expected_result: Optional[str], dttm: datetime
) -> None:
from superset.db_engine_specs.databend import DatabendEngineSpec as spec

assert_convert_dttm(spec, target_type, expected_result, dttm)


@pytest.mark.parametrize(
"native_type,sqla_type,attrs,generic_type,is_dttm",
[
Expand Down Expand Up @@ -119,7 +103,7 @@ def test_connect_convert_dttm(
("Nullable(Datetime)", DateTime, None, GenericDataType.TEMPORAL, True),
],
)
def test_connect_get_column_spec(
def test_get_column_spec(
native_type: str,
sqla_type: Type[TypeEngine],
attrs: Optional[Dict[str, Any]],
Expand All @@ -138,7 +122,7 @@ def test_connect_get_column_spec(
("count", "count_e2942a"),
],
)
def test_connect_make_label_compatible(column_name: str, expected_result: str) -> None:
def test_make_label_compatible(column_name: str, expected_result: str) -> None:
from superset.db_engine_specs.databend import DatabendConnectEngineSpec as spec

label = spec.make_label_compatible(column_name)
Expand Down

0 comments on commit 26581b9

Please sign in to comment.