fix types

apache · Dec 15, 2020 · 301165d · 301165d
1 parent 3a91dc8
commit 301165d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/superset-frontend/src/views/CRUD/alert/AlertList.tsx b/superset-frontend/src/views/CRUD/alert/AlertList.tsx
@@ -107,7 +107,9 @@ function AlertList({
   );
 
   const [alertModalOpen, setAlertModalOpen] = useState<boolean>(false);
-  const [currentAlert, setCurrentAlert] = useState<AlertObject | null>(null);
+  const [currentAlert, setCurrentAlert] = useState<Partial<AlertObject> | null>(
+    null,
+  );
   const [
     currentAlertDeleting,
     setCurrentAlertDeleting,

diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
@@ -450,7 +450,9 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
   isReport = false,
 }) => {
   const [disableSave, setDisableSave] = useState<boolean>(true);
-  const [currentAlert, setCurrentAlert] = useState<AlertObject | null>();
+  const [currentAlert, setCurrentAlert] = useState<Partial<
+    AlertObject
+  > | null>();
   const [isHidden, setIsHidden] = useState<boolean>(true);
   const [contentType, setContentType] = useState<string>('dashboard');
   // Dropdown options
@@ -749,9 +751,9 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
   const updateAlertState = (name: string, value: any) => {
     const data = {
       ...currentAlert,
+      [name]: value,
     };
 
-    data[name] = value;
     setCurrentAlert(data);
   };