fix(chart & alert): make to restore metrics control alert slice

apache · May 4, 2022 · 30d7f09 · 30d7f09
1 parent 02fb6ef
commit 30d7f09
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/superset-frontend/src/components/AlteredSliceTag/index.jsx b/superset-frontend/src/components/AlteredSliceTag/index.jsx
@@ -147,11 +147,15 @@ export default class AlteredSliceTag extends React.Component {
  if (controlsMap[key]?.type === 'CollectionControl') {
  return value.map(v => safeStringify(v)).join(', ');
  }
+ if (controlsMap[key]?.type === 'MetricsControl' && value.constructor === Array) {
+ const formattedValue = value.map(v => (v?.label ?? v));
+ return formattedValue.length ? formattedValue.join(', ') : '[]';
+ }
  if (typeof value === 'boolean') {
  return value ? 'true' : 'false';
  }
  if (value.constructor === Array) {
- const formattedValue = value.map(v => (v.label ? v.label : v));
+ const formattedValue = value.map(v => (v?.label ?? v));
  return formattedValue.length ? formattedValue.join(', ') : '[]';
  }
  if (typeof value === 'string' || typeof value === 'number') {