raise if instance type is not valid

superset/datasets/commands/importers/v0.py

@@ -29,6 +29,7 @@
 from superset.connectors.base.models import BaseColumn, BaseDatasource, BaseMetric
 from superset.connectors.sqla.models import SqlaTable, SqlMetric, TableColumn
 from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.datasets.commands.exceptions import DatasetInvalidError
 from superset.models.core import Database
 from superset.utils.dict_import_export import DATABASES_KEY
 
@@ -77,6 +78,9 @@ def import_dataset(
  lookup_database = lookup_sqla_database
  lookup_datasource = lookup_sqla_table
 
+ else:
+ raise DatasetInvalidError
+
  return import_datasource(
  db.session,
  i_datasource,
@@ -101,6 +105,8 @@ def lookup_sqla_metric(session: Session, metric: SqlMetric) -> SqlMetric:
 def import_metric(session: Session, metric: BaseMetric) -> BaseMetric:
  if isinstance(metric, SqlMetric):
  lookup_metric = lookup_sqla_metric
+ else:
+ raise Exception(f"Invalid metric type: {metric}")
  return import_simple_obj(session, metric, lookup_metric)
 
 
@@ -118,6 +124,8 @@ def lookup_sqla_column(session: Session, column: TableColumn) -> TableColumn:
 def import_column(session: Session, column: BaseColumn) -> BaseColumn:
  if isinstance(column, TableColumn):
  lookup_column = lookup_sqla_column
+ else:
+ raise Exception(f"Invalid column type: {column}")
  return import_simple_obj(session, column, lookup_column)