refactor: remove slice level label_colors from dashboard init load (#…

…10603)
apache · Aug 19, 2020 · 3bc7919 · 3bc7919
1 parent a3ac506
commit 3bc7919
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/superset/config.py b/superset/config.py
@@ -304,6 +304,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
  # Exposes API endpoint to compute thumbnails
  "THUMBNAILS": False,
  "REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD": True,
+ "REMOVE_SLICE_LEVEL_LABEL_COLORS": False,
  "SHARE_QUERIES_VIA_KV_STORE": False,
  "SIP_38_VIZ_REARCHITECTURE": False,
  "TAGGING_SYSTEM": False,

diff --git a/superset/views/core.py b/superset/views/core.py
@@ -1652,6 +1652,13 @@ def dashboard(**_: Any) -> None:
  )
 
  dashboard_data = dash.data
+ if is_feature_enabled("REMOVE_SLICE_LEVEL_LABEL_COLORS"):
+ # dashboard metadata has dashboard-level label_colors,
+ # so remove slice-level label_colors from its form_data
+ for slc in dashboard_data.get("slices"):
+ form_data = slc.get("form_data")
+ form_data.pop("label_colors", None)
+
  dashboard_data.update(
  {
  "standalone_mode": standalone_mode,