Skip to content

Commit

Permalink
deprecating SESSION_USE_SIGNER
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Mar 27, 2024
1 parent 1e4d457 commit 3c80bc0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 3 additions & 0 deletions UPDATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ assists people when migrating to a new version.
files for production use cases! While we never really supported
or should have tried to support docker-compose for production use cases, we now actively
have taken a stance against supporting it. See the PR for details.
- [27697](https://github.com/apache/superset/pull/27697) [minor] flask-session bump leads to them
deprecating `SESSION_USE_SIGNER`, check your configs as this flag won't do anything moving
forward.

### Breaking Changes

Expand Down
3 changes: 1 addition & 2 deletions superset/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -1474,7 +1474,6 @@ def EMAIL_HEADER_MUTATOR( # pylint: disable=invalid-name,unused-argument
# from flask_session import RedisSessionInterface
#
# SESSION_SERVER_SIDE = True
# SESSION_USE_SIGNER = True
# SESSION_TYPE = "redis"
# SESSION_REDIS = Redis(host="localhost", port=6379, db=0)
#
Expand Down Expand Up @@ -1704,7 +1703,7 @@ class ExtraDynamicQueryFilters(TypedDict, total=False):
try:
# pylint: disable=import-error,wildcard-import,unused-wildcard-import
import superset_config
from superset_config import * # type: ignore
from superset_config import *

Check warning on line 1706 in superset/config.py

View check run for this annotation

Codecov / codecov/patch

superset/config.py#L1706

Added line #L1706 was not covered by tests

print(f"Loaded your LOCAL configuration at [{superset_config.__file__}]")
except Exception:
Expand Down

0 comments on commit 3c80bc0

Please sign in to comment.