Skip to content

Commit

Permalink
bump to fixed FAB
Browse files Browse the repository at this point in the history
  • Loading branch information
dpgaspar committed Jun 6, 2024
1 parent 95144da commit 3ce8970
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ dependencies = [
"cryptography>=42.0.4, <43.0.0",
"deprecation>=2.1.0, <2.2.0",
"flask>=2.2.5, <3.0.0",
"flask-appbuilder==5.0.0a1",
"flask-appbuilder==5.0.0a2",
"flask-caching>=2.1.0, <3",
"flask-compress>=1.13, <2.0",
"flask-talisman>=1.0.0, <2.0",
Expand Down
2 changes: 1 addition & 1 deletion requirements/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ flask==2.3.3
# flask-session
# flask-sqlalchemy
# flask-wtf
flask-appbuilder==5.0.0a1
flask-appbuilder==5.0.0a2
# via apache-superset
flask-babel==2.0.0
# via flask-appbuilder
Expand Down
8 changes: 4 additions & 4 deletions superset/daos/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def find_by_id(
"""
query = db.session.query(cls.model_cls)
if cls.base_filter and not skip_base_filter:
data_model = SQLAInterface(cls.model_cls, db.session)
data_model = SQLAInterface(cls.model_cls)
query = cls.base_filter( # pylint: disable=not-callable
cls.id_column_name, data_model
).apply(query, None)
Expand All @@ -90,7 +90,7 @@ def find_by_ids(
return []
query = db.session.query(cls.model_cls).filter(id_col.in_(model_ids))
if cls.base_filter and not skip_base_filter:
data_model = SQLAInterface(cls.model_cls, db.session)
data_model = SQLAInterface(cls.model_cls)
query = cls.base_filter( # pylint: disable=not-callable
cls.id_column_name, data_model
).apply(query, None)
Expand All @@ -103,7 +103,7 @@ def find_all(cls) -> list[T]:
"""
query = db.session.query(cls.model_cls)
if cls.base_filter:
data_model = SQLAInterface(cls.model_cls, db.session)
data_model = SQLAInterface(cls.model_cls)
query = cls.base_filter( # pylint: disable=not-callable
cls.id_column_name, data_model
).apply(query, None)
Expand All @@ -116,7 +116,7 @@ def find_one_or_none(cls, **filter_by: Any) -> T | None:
"""
query = db.session.query(cls.model_cls)
if cls.base_filter:
data_model = SQLAInterface(cls.model_cls, db.session)
data_model = SQLAInterface(cls.model_cls)
query = cls.base_filter( # pylint: disable=not-callable
cls.id_column_name, data_model
).apply(query, None)
Expand Down
2 changes: 1 addition & 1 deletion superset/daos/dashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def get_by_id_or_slug(cls, id_or_slug: int | str) -> Dashboard:
.outerjoin(Dashboard.roles)
)
# Apply dashboard base filters
query = cls.base_filter("id", SQLAInterface(Dashboard, db.session)).apply(
query = cls.base_filter("id", SQLAInterface(Dashboard)).apply(
query, None
)
dashboard = query.one_or_none()
Expand Down
4 changes: 2 additions & 2 deletions superset/reports/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class ReportSchedule(AuditMixinNullable, ExtraJSONMixin, Model):
"""
Report Schedules, supports alerts and reports
"""

__allow_unmapped__ = True
__tablename__ = "report_schedule"
__table_args__ = (UniqueConstraint("name", "type"),)

Expand Down Expand Up @@ -171,7 +171,7 @@ class ReportSchedule(AuditMixinNullable, ExtraJSONMixin, Model):
custom_width = Column(Integer, nullable=True)
custom_height = Column(Integer, nullable=True)

extra: Mapped[ReportScheduleExtra] = Column(Text, default="{}") # type: ignore
extra: ReportScheduleExtra

email_subject = Column(String(255))

Expand Down

0 comments on commit 3ce8970

Please sign in to comment.