prevent extra div if not truncating

apache · May 25, 2022 · 4a236a8 · 4a236a8
1 parent 10fa3bb
commit 4a236a8
Showing 1 changed file with 13 additions and 13 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
@@ -412,20 +412,20 @@ export default function TableChart<D extends DataRecord = DataRecord>(
  ].join(' '),
  };
  if (html) {
+ if (truncateLongCells) {
+ // eslint-disable-next-line react/no-danger
+ return (
+ <StyledCell {...cellProps}>
+ <div
+ className="dt-truncate-cell"
+ style={columnWidth ? { width: columnWidth } : undefined}
+ dangerouslySetInnerHTML={html}
+ />
+ </StyledCell>
+ );
+ }
  // eslint-disable-next-line react/no-danger
- return (
- <StyledCell {...cellProps}>
- <div
- {...(truncateLongCells
- ? {
- className: 'dt-truncate-cell',
- style: columnWidth ? { width: columnWidth } : undefined,
- }
- : undefined)}
- dangerouslySetInnerHTML={html}
- />
- </StyledCell>
- );
+ return <StyledCell {...cellProps} dangerouslySetInnerHTML={html} />;
  }
  // If cellProps renderes textContent already, then we don't have to
  // render `Cell`. This saves some time for large tables.