fix(sqllab): Replace margin style by gap on query results (#24772)

apache · Jul 25, 2023 · 4a81284 · 4a81284
1 parent fc89718
commit 4a81284
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/superset-frontend/src/SqlLab/components/ResultSet/index.tsx b/superset-frontend/src/SqlLab/components/ResultSet/index.tsx
@@ -81,6 +81,12 @@ export interface ResultSetProps {
  defaultQueryLimit: number;
 }
 
+const ResultContainer = styled.div`
+ display: flex;
+ flex-direction: column;
+ row-gap: ${({ theme }) => theme.gridUnit * 2}px;
+`;
+
 const ResultlessStyles = styled.div`
  position: relative;
  min-height: ${({ theme }) => theme.gridUnit * 25}px;
@@ -110,7 +116,6 @@ const ReturnedRows = styled.div`
 const ResultSetControls = styled.div`
  display: flex;
  justify-content: space-between;
- padding: ${({ theme }) => 2 * theme.gridUnit}px 0;
 `;
 
 const ResultSetButtons = styled.div`
@@ -494,7 +499,7 @@ const ResultSet = ({
  ? results.expanded_columns.map(col => col.column_name)
  : [];
  return (
- <>
+ <ResultContainer>
  {renderControls()}
  {renderRowsReturned()}
  {sql}
@@ -505,7 +510,7 @@ const ResultSet = ({
  filterText={searchText}
  expandedColumns={expandedColumns}
  />
- </>
+ </ResultContainer>
  );
  }
  if (data && data.length === 0) {

diff --git a/superset-frontend/src/SqlLab/components/SouthPane/index.tsx b/superset-frontend/src/SqlLab/components/SouthPane/index.tsx
@@ -71,8 +71,6 @@ const StyledPane = styled.div<StyledPaneProps>`
  }
  }
  .ant-tabs-tabpane {
- display: flex;
- flex-direction: column;
  .scrollable {
  overflow-y: auto;
  }

diff --git a/superset-frontend/src/components/FilterableTable/index.tsx b/superset-frontend/src/components/FilterableTable/index.tsx
@@ -77,7 +77,6 @@ const StyledFilterableTable = styled.div`
  ${({ theme }) => `
  height: 100%;
  overflow: hidden;
- margin-top: ${theme.gridUnit * 2}px;
 
  .ant-table-cell {
  font-weight: ${theme.typography.weights.bold};