Fixes lint problems

apache · Jun 9, 2023 · 4c106d0 · 4c106d0
1 parent 4ddd593
commit 4c106d0
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 11 deletions.
diff --git a/superset-frontend/src/pages/ChartList/index.tsx b/superset-frontend/src/pages/ChartList/index.tsx
@@ -68,7 +68,6 @@ import setupPlugins from 'src/setup/setupPlugins';
 import InfoTooltip from 'src/components/InfoTooltip';
 import CertifiedBadge from 'src/components/CertifiedBadge';
 import { GenericLink } from 'src/components/GenericLink/GenericLink';
-import getBootstrapData from 'src/utils/getBootstrapData';
 import Owner from 'src/types/Owner';
 import { loadTags } from 'src/components/Tags/utils';
 import ChartCard from 'src/features/charts/ChartCard';
@@ -156,8 +155,6 @@ const StyledActions = styled.div`
  color: ${({ theme }) => theme.colors.grayscale.base};
 `;
 
-const bootstrapData = getBootstrapData();
-
 function ChartList(props: ChartListProps) {
  const {
  addDangerToast,

diff --git a/superset-frontend/src/pages/DashboardList/index.tsx b/superset-frontend/src/pages/DashboardList/index.tsx
@@ -54,7 +54,6 @@ import Dashboard from 'src/dashboard/containers/Dashboard';
 import { Dashboard as CRUDDashboard } from 'src/views/CRUD/types';
 import CertifiedBadge from 'src/components/CertifiedBadge';
 import { loadTags } from 'src/components/Tags/utils';
-import getBootstrapData from 'src/utils/getBootstrapData';
 import DashboardCard from 'src/features/dashboards/DashboardCard';
 import { DashboardStatus } from 'src/features/dashboards/types';
 
@@ -101,8 +100,6 @@ const Actions = styled.div`
  color: ${({ theme }) => theme.colors.grayscale.base};
 `;
 
-const bootstrapData = getBootstrapData();
-
 function DashboardList(props: DashboardListProps) {
  const {
  addDangerToast,

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -32,7 +32,7 @@
 import pandas as pd
 import sqlalchemy as sa
 import sqlparse
-from flask import current_app, escape, Markup
+from flask import escape, Markup
 from flask_appbuilder import Model
 from flask_babel import lazy_gettext as _
 from jinja2.exceptions import TemplateError

diff --git a/superset/models/dashboard.py b/superset/models/dashboard.py
@@ -24,7 +24,6 @@
 from typing import Any, Callable
 
 import sqlalchemy as sqla
-from flask import current_app
 from flask_appbuilder import Model
 from flask_appbuilder.models.decorators import renders
 from flask_appbuilder.security.sqla.models import User

diff --git a/superset/models/filter_set.py b/superset/models/filter_set.py
@@ -20,7 +20,6 @@
 import logging
 from typing import Any
 
-from flask import current_app
 from flask_appbuilder import Model
 from sqlalchemy import Column, ForeignKey, Integer, MetaData, String, Text
 from sqlalchemy.orm import relationship

diff --git a/superset/models/slice.py b/superset/models/slice.py
@@ -22,7 +22,6 @@
 from urllib import parse
 
 import sqlalchemy as sqla
-from flask import current_app
 from flask_appbuilder import Model
 from flask_appbuilder.models.decorators import renders
 from markupsafe import escape, Markup

diff --git a/superset/security/manager.py b/superset/security/manager.py
@@ -59,7 +59,6 @@
  DatasetInvalidPermissionEvaluationException,
  SupersetSecurityException,
 )
-from superset.extensions import feature_flag_manager
 from superset.security.guest_token import (
  GuestToken,
  GuestTokenResources,
@@ -2005,6 +2004,8 @@ def get_rls_cache_key(self, datasource: "BaseDatasource") -> list[str]:
 
  @staticmethod
  def raise_for_user_activity_access(user_id: int) -> None:
+ from superset.extensions import feature_flag_manager
+
  if not get_user_id() or (
  not feature_flag_manager.is_feature_enabled("ENABLE_BROAD_ACTIVITY_ACCESS")
  and user_id != get_user_id()