fix: Revert shared controls typing change. (#22014)

apache · Nov 3, 2022 · 4cbd70d · 4cbd70d
1 parent ba65f66
commit 4cbd70d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/types.ts b/superset-frontend/packages/superset-ui-chart-controls/src/types.ts
@@ -242,7 +242,7 @@ export interface BaseControlConfig<
  ) => boolean;
  mapStateToProps?: (
  state: ControlPanelState,
- controlState?: ControlState,
+ controlState: ControlState,
  // TODO: add strict `chartState` typing (see superset-frontend/src/explore/types)
  chartState?: AnyDict,
  ) => ExtraControlProps;

diff --git a/superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-histogram/src/controlPanel.ts
@@ -25,14 +25,15 @@ import {
  sections,
  getStandardizedControls,
  sharedControls,
+ ControlState,
 } from '@superset-ui/chart-controls';
 
 const columnsConfig = {
  ...sharedControls.columns,
  label: t('Columns'),
  description: t('Select the numeric columns to draw the histogram'),
- mapStateToProps: (state: ControlPanelState) => ({
- ...(sharedControls.columns.mapStateToProps?.(state) || {}),
+ mapStateToProps: (state: ControlPanelState, controlState: ControlState) => ({
+ ...(sharedControls.columns.mapStateToProps?.(state, controlState) || {}),
  choices: columnChoices(state.datasource),
  }),
  validators: [validateNonEmpty],