fix(sqllab): Disable Select All on table selector (#24120)

apache · May 18, 2023 · 5159861 · 5159861
1 parent 2222073
commit 5159861
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/superset-frontend/src/components/TableSelector/TableSelector.test.tsx b/superset-frontend/src/components/TableSelector/TableSelector.test.tsx
@@ -95,7 +95,26 @@ test('renders with default props', async () => {
  });
 });
 
-test('renders table options', async () => {
+test('skips select all options', async () => {
+ fetchMock.get(schemaApiRoute, { result: ['test_schema'] });
+ fetchMock.get(tablesApiRoute, getTableMockFunction());
+
+ const props = createProps();
+ render(<TableSelector {...props} tableSelectMode="multiple" />, {
+ useRedux: true,
+ store,
+ });
+ const tableSelect = screen.getByRole('combobox', {
+ name: 'Select table or type to search tables',
+ });
+ userEvent.click(tableSelect);
+ expect(
+ await screen.findByRole('option', { name: 'table_a' }),
+ ).toBeInTheDocument();
+ expect(screen.queryByRole('option', { name: /Select All/i })).toBeFalsy();
+});
+
+test('renders table options without Select All option', async () => {
  fetchMock.get(schemaApiRoute, { result: ['test_schema'] });
  fetchMock.get(tablesApiRoute, getTableMockFunction());
 

diff --git a/superset-frontend/src/components/TableSelector/index.tsx b/superset-frontend/src/components/TableSelector/index.tsx
@@ -297,6 +297,7 @@ const TableSelector: FunctionComponent<TableSelectorProps> = ({
  mode={tableSelectMode}
  value={tableSelectValue}
  allowClear={tableSelectMode === 'multiple'}
+ allowSelectAll={false}
  />
  );