fix: dashboard api cache decorator (#21964)

apache · Nov 2, 2022 · 5773195 · 5773195
1 parent 70b0a96
commit 5773195
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/superset/dashboards/api.py b/superset/dashboards/api.py
@@ -271,6 +271,8 @@ def __repr__(self) -> str:
  self.appbuilder.app.config["VERSION_SHA"],
  )
 
+ @expose("/<id_or_slug>", methods=["GET"])
+ @protect()
  @etag_cache(
  get_last_modified=lambda _self, id_or_slug: DashboardDAO.get_dashboard_changed_on( # pylint: disable=line-too-long,useless-suppression
  id_or_slug
@@ -281,8 +283,6 @@ def __repr__(self) -> str:
  ),
  skip=lambda _self, id_or_slug: not is_feature_enabled("DASHBOARD_CACHE"),
  )
- @expose("/<id_or_slug>", methods=["GET"])
- @protect()
  @safe
  @statsd_metrics
  @event_logger.log_this_with_context(
@@ -325,6 +325,8 @@ def get(self, dash: Dashboard) -> Response:
  result = self.dashboard_get_response_schema.dump(dash)
  return self.response(200, result=result)
 
+ @expose("/<id_or_slug>/datasets", methods=["GET"])
+ @protect()
  @etag_cache(
  get_last_modified=lambda _self, id_or_slug: DashboardDAO.get_dashboard_and_datasets_changed_on( # pylint: disable=line-too-long,useless-suppression
  id_or_slug
@@ -335,8 +337,6 @@ def get(self, dash: Dashboard) -> Response:
  ),
  skip=lambda _self, id_or_slug: not is_feature_enabled("DASHBOARD_CACHE"),
  )
- @expose("/<id_or_slug>/datasets", methods=["GET"])
- @protect()
  @safe
  @statsd_metrics
  @event_logger.log_this_with_context(
@@ -388,6 +388,8 @@ def get_datasets(self, id_or_slug: str) -> Response:
  except DashboardNotFoundError:
  return self.response_404()
 
+ @expose("/<id_or_slug>/charts", methods=["GET"])
+ @protect()
  @etag_cache(
  get_last_modified=lambda _self, id_or_slug: DashboardDAO.get_dashboard_and_slices_changed_on( # pylint: disable=line-too-long,useless-suppression
  id_or_slug
@@ -398,8 +400,6 @@ def get_datasets(self, id_or_slug: str) -> Response:
  ),
  skip=lambda _self, id_or_slug: not is_feature_enabled("DASHBOARD_CACHE"),
  )
- @expose("/<id_or_slug>/charts", methods=["GET"])
- @protect()
  @safe
  @statsd_metrics
  @event_logger.log_this_with_context(