Skip to content

Commit

Permalink
Fixing pylint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Vitor-Avila committed Jan 20, 2024
1 parent 5d8da87 commit 5a0f752
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion superset/commands/dashboard/importers/v0.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def import_chart(


def import_dashboard(
# pylint: disable=too-many-branches,too-many-locals,too-many-statements
# pylint: disable=too-many-locals,too-many-statements
dashboard_to_import: Dashboard,
dataset_id_mapping: Optional[dict[int, int]] = None,
import_time: Optional[int] = None,
Expand Down
2 changes: 1 addition & 1 deletion superset/tags/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ class UserCreatedTagTypeFilter(BaseFilter): # pylint: disable=too-few-public-me
def apply(self, query: Query, value: bool) -> Query:
if value:
return query.filter(Tag.type == TagType.custom)
elif value is False:
if value is False:
return query.filter(Tag.type != TagType.custom)
return query

Check warning on line 39 in superset/tags/filters.py

View check run for this annotation

Codecov / codecov/patch

superset/tags/filters.py#L39

Added line #L39 was not covered by tests
1 change: 0 additions & 1 deletion superset/views/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License.
# pylint: disable=invalid-name
# pylint: disable=too-many-lines
from __future__ import annotations

import contextlib
Expand Down

0 comments on commit 5a0f752

Please sign in to comment.