feat: Persist SQL Lab autocomplete setting across tabs and visits (#1…

…7708)
apache · Dec 20, 2021 · 5b0aa27 · 5b0aa27
1 parent 6edc183
commit 5b0aa27
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/superset-frontend/src/SqlLab/components/SqlEditor/index.jsx b/superset-frontend/src/SqlLab/components/SqlEditor/index.jsx
@@ -63,6 +63,11 @@ import {
  SQL_EDITOR_GUTTER_MARGIN,
  SQL_TOOLBAR_HEIGHT,
 } from 'src/SqlLab/constants';
+import {
+ getItem,
+ LocalStorageKeys,
+ setItem,
+} from 'src/utils/localStorageHelpers';
 import { FeatureFlag, isFeatureEnabled } from 'src/featureFlags';
 import TemplateParamsEditor from '../TemplateParamsEditor';
 import ConnectedSouthPane from '../SouthPane/state';
@@ -171,7 +176,10 @@ class SqlEditor extends React.PureComponent {
  northPercent: props.queryEditor.northPercent || INITIAL_NORTH_PERCENT,
  southPercent: props.queryEditor.southPercent || INITIAL_SOUTH_PERCENT,
  sql: props.queryEditor.sql,
- autocompleteEnabled: true,
+ autocompleteEnabled: getItem(
+ LocalStorageKeys.sqllab__is_autocomplete_enabled,
+ true,
+ ),
  showCreateAsModal: false,
  createAs: '',
  };
@@ -365,9 +373,15 @@ class SqlEditor extends React.PureComponent {
  }
 
  handleToggleAutocompleteEnabled = () => {
- this.setState(prevState => ({
- autocompleteEnabled: !prevState.autocompleteEnabled,
- }));
+ this.setState(prevState => {
+ setItem(
+ LocalStorageKeys.sqllab__is_autocomplete_enabled,
+ !prevState.autocompleteEnabled,
+ );
+ return {
+ autocompleteEnabled: !prevState.autocompleteEnabled,
+ };
+ });
  };
 
  handleWindowResize() {

diff --git a/superset-frontend/src/utils/localStorageHelpers.ts b/superset-frontend/src/utils/localStorageHelpers.ts
@@ -48,6 +48,7 @@ export enum LocalStorageKeys {
  * Example:
  * sqllab__is_autocomplete_enabled
  */
+ sqllab__is_autocomplete_enabled = 'sqllab__is_autocomplete_enabled',
 }
 
 export type LocalStorageValues = {
@@ -60,6 +61,7 @@ export type LocalStorageValues = {
  homepage_dashboard_filter: TableTabTypes;
  homepage_collapse_state: string[];
  homepage_activity_filter: SetTabType | null;
+ sqllab__is_autocomplete_enabled: boolean;
 };
 
 export function getItem<K extends LocalStorageKeys>(