chore: Remove dependency warnings from SqlEditorLeftBar/index.tsx (#2…

…2975)
apache · Feb 15, 2023 · 76f7a3f · 76f7a3f
1 parent 1324135
commit 76f7a3f
Showing 1 changed file with 37 additions and 22 deletions.
diff --git a/superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx b/superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
@@ -210,35 +210,50 @@ const SqlEditorLeftBar = ({
   const shouldShowReset = window.location.search === '?reset=1';
   const tableMetaDataHeight = height - 130; // 130 is the height of the selects above
 
-  const handleSchemaChange = useCallback((schema: string) => {
-    if (queryEditor) {
-      dispatch(queryEditorSetSchema(queryEditor, schema));
-    }
-  }, []);
+  const handleSchemaChange = useCallback(
+    (schema: string) => {
+      if (queryEditor) {
+        dispatch(queryEditorSetSchema(queryEditor, schema));
+      }
+    },
+    [dispatch, queryEditor],
+  );
 
-  const handleTablesLoad = useCallback((options: Array<any>) => {
-    if (queryEditor) {
-      dispatch(queryEditorSetTableOptions(queryEditor, options));
-    }
-  }, []);
+  const handleTablesLoad = useCallback(
+    (options: Array<any>) => {
+      if (queryEditor) {
+        dispatch(queryEditorSetTableOptions(queryEditor, options));
+      }
+    },
+    [dispatch, queryEditor],
+  );
 
-  const handleSchemasLoad = useCallback((options: Array<any>) => {
-    if (queryEditor) {
-      dispatch(queryEditorSetSchemaOptions(queryEditor, options));
-    }
-  }, []);
+  const handleSchemasLoad = useCallback(
+    (options: Array<any>) => {
+      if (queryEditor) {
+        dispatch(queryEditorSetSchemaOptions(queryEditor, options));
+      }
+    },
+    [dispatch, queryEditor],
+  );
 
-  const handleDbList = useCallback((result: DatabaseObject) => {
-    dispatch(setDatabases(result));
-  }, []);
+  const handleDbList = useCallback(
+    (result: DatabaseObject) => {
+      dispatch(setDatabases(result));
+    },
+    [dispatch],
+  );
 
-  const handleError = useCallback((message: string) => {
-    dispatch(addDangerToast(message));
-  }, []);
+  const handleError = useCallback(
+    (message: string) => {
+      dispatch(addDangerToast(message));
+    },
+    [dispatch],
+  );
 
   const handleResetState = useCallback(() => {
     dispatch(resetState());
-  }, []);
+  }, [dispatch]);
 
   return (
     <LeftBarStyles data-test="sql-editor-left-bar">