Skip to content

Commit

Permalink
[charts] feat: add statsd to charts api (#9571)
Browse files Browse the repository at this point in the history
* add statsd to charts api

* update test for charts api

* [charts] add statsd asserts wrapper

* [charts] update api test

* removed white space
  • Loading branch information
Lily Kuang authored Apr 21, 2020
1 parent ba691d3 commit 7cefc89
Show file tree
Hide file tree
Showing 2 changed files with 73 additions and 62 deletions.
12 changes: 11 additions & 1 deletion superset/charts/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@
from superset.tasks.thumbnails import cache_chart_thumbnail
from superset.utils.core import json_int_dttm_ser
from superset.utils.screenshots import ChartScreenshot
from superset.views.base_api import BaseSupersetModelRestApi, RelatedFieldFilter
from superset.views.base_api import (
BaseSupersetModelRestApi,
RelatedFieldFilter,
statsd_metrics,
)
from superset.views.filters import FilterRelatedOwners

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -147,6 +151,7 @@ def __init__(self) -> None:
@expose("/", methods=["POST"])
@protect()
@safe
@statsd_metrics
def post(self) -> Response:
"""Creates a new Chart
---
Expand Down Expand Up @@ -199,6 +204,7 @@ def post(self) -> Response:
@expose("/<pk>", methods=["PUT"])
@protect()
@safe
@statsd_metrics
def put( # pylint: disable=too-many-return-statements, arguments-differ
self, pk: int
) -> Response:
Expand Down Expand Up @@ -266,6 +272,7 @@ def put( # pylint: disable=too-many-return-statements, arguments-differ
@expose("/<pk>", methods=["DELETE"])
@protect()
@safe
@statsd_metrics
def delete(self, pk: int) -> Response: # pylint: disable=arguments-differ
"""Deletes a Chart
---
Expand Down Expand Up @@ -312,6 +319,7 @@ def delete(self, pk: int) -> Response: # pylint: disable=arguments-differ
@expose("/", methods=["DELETE"])
@protect()
@safe
@statsd_metrics
@rison(get_delete_ids_schema)
def bulk_delete(
self, **kwargs: Any
Expand Down Expand Up @@ -373,6 +381,7 @@ def bulk_delete(
@event_logger.log_this
@protect()
@safe
@statsd_metrics
def data(self) -> Response:
"""
Takes a query context constructed in the client and returns payload
Expand Down Expand Up @@ -429,6 +438,7 @@ def data(self) -> Response:
@protect()
@rison(thumbnail_query_schema)
@safe
@statsd_metrics
def thumbnail(
self, pk: int, digest: str, **kwargs: Dict[str, bool]
) -> WerkzeugResponse:
Expand Down
Loading

0 comments on commit 7cefc89

Please sign in to comment.