Add test

apache · Nov 6, 2023 · 7f6b422 · 7f6b422
1 parent 491a2ce
commit 7f6b422
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/superset/db_engine_specs/base.py b/superset/db_engine_specs/base.py
@@ -400,8 +400,8 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
 
  @classmethod
  def get_allows_alias_in_select(
- cls, database: Database
- ) -> bool: # pylint: disable=unused-argument
+ cls, database: Database # pylint: disable=unused-argument
+ ) -> bool:
  """
  Method for dynamic `allows_alias_in_select`.
 

diff --git a/tests/unit_tests/db_engine_specs/test_dremio.py b/tests/unit_tests/db_engine_specs/test_dremio.py
@@ -18,6 +18,7 @@
 from typing import Optional
 
 import pytest
+from pytest_mock import MockerFixture
 
 from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm
 from tests.unit_tests.fixtures.common import dttm
@@ -40,3 +41,18 @@ def test_convert_dttm(
  from superset.db_engine_specs.dremio import DremioEngineSpec as spec
 
  assert_convert_dttm(spec, target_type, expected_result, dttm)
+
+
+def test_get_allows_alias_in_select(mocker: MockerFixture) -> None:
+ from superset.db_engine_specs.dremio import DremioEngineSpec
+
+ database = mocker.MagicMock()
+
+ database.get_extra.return_value = {}
+ assert DremioEngineSpec.get_allows_alias_in_select(database) is True
+
+ database.get_extra.return_value = {"version": "24.1.0"}
+ assert DremioEngineSpec.get_allows_alias_in_select(database) is True
+
+ database.get_extra.return_value = {"version": "24.0.0"}
+ assert DremioEngineSpec.get_allows_alias_in_select(database) is False