Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ci): Docker master builds fail while checking version
In #27055, I broke the master builds while making the `run_cmd` method raise if it gets a non-zero exit status. Turned out to only fail while in the `pull_request` context. This is the change: https://github.com/apache/superset/pull/27055/files#diff-3cf86f687684a2c690521532de75a831def641338f5a9ec1da8add94714def4cR44-R45 This is the observed error in master build ``` Traceback (most recent call last): {...REDACTED...} File "/home/runner/work/superset/superset/./scripts/build_docker.py", line 76, in is_latest_release output = run_cmd(f"./scripts/tag_latest_release.sh {release} --dry-run") or "" File "/home/runner/work/superset/superset/./scripts/build_docker.py", line 45, in run_cmd raise subprocess.CalledProcessError(process.returncode, command, output) subprocess.CalledProcessError: Command './scripts/tag_latest_release.sh master --dry-run' returned non-zero exit status 1. Error: Process completed with exit code 1. ``` This disregards the exit code the `tag_latest_release.sh` since it seems to be return error codes in expected situations.
- Loading branch information