Skip to content

Commit

Permalink
add UPDATING note and improve description
Browse files Browse the repository at this point in the history
  • Loading branch information
villebro committed Aug 15, 2023
1 parent af500e2 commit 8847cbd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions UPDATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ assists people when migrating to a new version.

### Other

- [24982](https://github.com/apache/superset/pull/24982): By default, physical datasets on Oracle-like dialects like Snowflake will now use denormalized column names. However, existing datasets won't be affected. To change this behavior, the "Advanced" section on the dataset modal has a "Normalize column names" flag which can be changed to change this behavior.

## 2.1.0

- [22809](https://github.com/apache/superset/pull/22809): Migrated endpoint `/superset/sql_json` and `/superset/results/` to `/api/v1/sqllab/execute/` and `/api/v1/sqllab/results/` respectively. Corresponding permissions are `can sql_json on Superset` to `can execute on SQLLab`, `can results on Superset` to `can results on SQLLab`. Make sure you add/replace the necessary permissions on any custom roles you may have.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,7 @@ class DatasourceEditor extends React.PureComponent {
fieldKey="normalize_columns"
label={t('Normalize column names')}
description={t(
'Allow column names to be changed to case insensitive format',
'Allow column names to be changed to case insensitive format, if supported (e.g. Oracle, Snowflake).',
)}
control={<CheckboxControl controlId="normalize_columns" />}
/>
Expand Down
3 changes: 2 additions & 1 deletion superset/connectors/sqla/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,8 @@ class TableModelView( # pylint: disable=too-many-ancestors
True,
),
"normalize_columns": _(
"Allow column names to be changed to case insensitive format"
"Allow column names to be changed to case insensitive format, "
"if supported (e.g. Oracle, Snowflake)."
),
}
label_columns = {
Expand Down

0 comments on commit 8847cbd

Please sign in to comment.