Skip to content

Commit

Permalink
chore: deprecarte pylint in favor of ruff
Browse files Browse the repository at this point in the history
This could be slightly controversial, but submitted as a DRAFT for discussion.

The case for pylint deprecation:
- mostly covered by ruff: what matters most in pylint is already re-implemented
- pylint is SLOW, ruff is a million times faster - pre-commit / pylint is one of our longest, most expensive CI step
- rules are currently scattered in different places and can conflict at times

Very relevant is this link that explains what pylint features are covered or not by ruff:
astral-sh/ruff#970

If we agree on the direction, the plan is to follow up and enable all the rules, apply `ruff check --fix` and `ruff check --add-no-qa`

Simplify.
  • Loading branch information
mistercrunch committed Dec 2, 2024
1 parent deec63b commit 89ec710
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 458 deletions.
14 changes: 0 additions & 14 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,3 @@ repos:
- id: ruff
args: [ --fix ]
- id: ruff-format
- repo: local
hooks:
- id: pylint
name: pylint
entry: pylint
language: system
types: [python]
exclude: ^(tests/|superset/migrations/|scripts/|RELEASING/|docker/)
args:
[
"-rn", # Only display messages
"-sn", # Don't display the score
"--rcfile=.pylintrc",
]
380 changes: 0 additions & 380 deletions .pylintrc

This file was deleted.

Loading

0 comments on commit 89ec710

Please sign in to comment.