Skip to content

Commit

Permalink
feat(snowflake): get_catalog_names (#23602)
Browse files Browse the repository at this point in the history
  • Loading branch information
betodealmeida authored Apr 6, 2023
1 parent 290920c commit 8d14420
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 0 deletions.
2 changes: 2 additions & 0 deletions superset/db_engine_specs/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ class BigQueryEngineSpec(BaseEngineSpec): # pylint: disable=too-many-public-met

allows_hidden_cc_in_orderby = True

supports_catalog = True

"""
https://www.python.org/dev/peps/pep-0249/#arraysize
raw_connections bypass the sqlalchemy-bigquery query execution context and deal with
Expand Down
1 change: 1 addition & 0 deletions superset/db_engine_specs/postgres.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ class PostgresBaseEngineSpec(BaseEngineSpec):
engine_name = "PostgreSQL"

supports_dynamic_schema = True
supports_catalog = True

_time_grain_expressions = {
None: "{col}",
Expand Down
20 changes: 20 additions & 0 deletions superset/db_engine_specs/snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from flask_babel import gettext as __
from marshmallow import fields, Schema
from sqlalchemy import types
from sqlalchemy.engine.reflection import Inspector
from sqlalchemy.engine.url import URL
from typing_extensions import TypedDict

Expand Down Expand Up @@ -84,6 +85,7 @@ class SnowflakeEngineSpec(PostgresBaseEngineSpec):
sqlalchemy_uri_placeholder = "snowflake://"

supports_dynamic_schema = True
supports_catalog = True

_time_grain_expressions = {
None: "{col}",
Expand Down Expand Up @@ -167,6 +169,24 @@ def get_schema_from_engine_params(

return parse.unquote(database.split("/")[1])

@classmethod
def get_catalog_names(
cls,
database: "Database",
inspector: Inspector,
) -> List[str]:
"""
Return all catalogs.
In Snowflake, a catalog is called a "database".
"""
return sorted(
catalog
for (catalog,) in inspector.bind.execute(
"SELECT DATABASE_NAME from information_schema.databases"
)
)

@classmethod
def epoch_to_dttm(cls) -> str:
return "DATEADD(S, {col}, '1970-01-01')"
Expand Down

0 comments on commit 8d14420

Please sign in to comment.